Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13284 )
Change subject: IMPALA-8281: Misc Sentry decoupling clean up ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/13284/7/tests/authorization/test_sentry.py File tests/authorization/test_sentry.py: http://gerrit.cloudera.org:8080/#/c/13284/7/tests/authorization/test_sentry.py@93 PS7, Line 93: finally: : self.client.execute("drop database {0}".format(unique_name)) : self.client.execute( > My mistake. This test case is invalid. Calling `drop role` on a non-existen I did a quick test from master, I don't think this behavior in this CR is correct. [localhost:21000] default> drop role non_role; Query: drop role non_role ERROR: AnalysisException: Role 'non_role' does not exist. -- To view, visit http://gerrit.cloudera.org:8080/13284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id24a00dd395e30e4c392f085893e9561da2ee539 Gerrit-Change-Number: 13284 Gerrit-PatchSet: 8 Gerrit-Owner: Austin Nobis <ano...@cloudera.com> Gerrit-Reviewer: Austin Nobis <ano...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 10 May 2019 16:36:35 +0000 Gerrit-HasComments: Yes