Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13313 )
Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config ...................................................................... Patch Set 1: One question about the usability of this: it seems the most common use case for impala-shell command line options is to specify security-related configs (--ssl, --kerberos, etc) as well as a host to connect to. If we put those in a global config file, we get a usability boost that 'impala-shell' by a user will directly connect to the right place. However, if the user wants to connect to a remote cluster with different security options (eg non-Kerberos or non-SSL) will it be confusing? For example, if I do 'impala-shell -i some-remote-cluster.example.com', I'll end up picking up the local cluster's Kerberos and SSL configurations. This might even be considered an incompatible change, if management tools start putting these configs in /etc/impalarc by default, and then scripts trying to connect to non-default locations change behavior. Does the impala config file format support scoping of settings by host (like .ssh/config does?) Is that something we should consider? If not, perhaps a compromise is to make sure connection errors include some information about where configs are being sourced from. -- To view, visit http://gerrit.cloudera.org:8080/13313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a3179b6d9c9e3b2b01d6d3c5847cadb68782816 Gerrit-Change-Number: 13313 Gerrit-PatchSet: 1 Gerrit-Owner: Ethan Xue <ethan....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 13 May 2019 17:17:17 +0000 Gerrit-HasComments: No
