Ethan Xue has posted comments on this change. ( http://gerrit.cloudera.org:8080/13313 )
Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/13313/1/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/13313/1/shell/impala_shell.py@1612 PS1, Line 1612: h > flake8: E501 line too long (92 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/13313/1/shell/impala_shell.py@1615 PS1, Line 1615: l > flake8: E501 line too long (92 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/13313/1/shell/impala_shell.py@1624 PS1, Line 1624: user_config = impala_shell_defaults.get("config_file") : global_config = impala_shell_defaults.get("global_config") > we should call these variables. Done http://gerrit.cloudera.org:8080/#/c/13313/1/shell/impala_shell_config_defaults.py File shell/impala_shell_config_defaults.py: http://gerrit.cloudera.org:8080/#/c/13313/1/shell/impala_shell_config_defaults.py@55 PS1, Line 55: .impalarc > Usually files in /etc are not dot files. So /etc/impalarc is better. Done http://gerrit.cloudera.org:8080/#/c/13313/1/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/13313/1/shell/option_parser.py@289 PS1, Line 289: n > flake8: E714 test for object identity should be 'is not' Done -- To view, visit http://gerrit.cloudera.org:8080/13313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a3179b6d9c9e3b2b01d6d3c5847cadb68782816 Gerrit-Change-Number: 13313 Gerrit-PatchSet: 1 Gerrit-Owner: Ethan Xue <ethan....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Ethan Xue <ethan....@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 13 May 2019 18:25:52 +0000 Gerrit-HasComments: Yes
