Todd Lipcon has posted comments on this change. (
http://gerrit.cloudera.org:8080/13286 )
Change subject: Update cmake to 3.14.3
......................................................................
Patch Set 1:
I don't think that's right. Looking at the CMakeLists.txt file, it has:
IF(DEFINED KWSYS_PROCESS_USE_SELECT)
GET_PROPERTY(ProcessUNIX_FLAGS SOURCE ProcessUNIX.c PROPERTY COMPILE_FLAGS)
SET_PROPERTY(SOURCE ProcessUNIX.c PROPERTY COMPILE_FLAGS
"${ProcessUNIX_FLAGS} -DKWSYSPE_USE_SELECT=${KWSYSPE_USE_SELECT}")
ENDIF()
So the correct one is KWSYS_PROCESS_USE_SELECT. Not sure why the build failed
with that one.
--
To view, visit http://gerrit.cloudera.org:8080/13286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ad46a7b820bbb727ce47219f03f1d4a36301ab4
Gerrit-Change-Number: 13286
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Comment-Date: Mon, 13 May 2019 22:48:59 +0000
Gerrit-HasComments: No
