Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13286 )
Change subject: Update cmake to 3.14.3 ...................................................................... Update cmake to 3.14.3 This updates to the latest cmake, which includes a few improvements that may be helpful. In particular, the Ninja generator avoids generating some false dependencies[1] Instead of carrying over the patch to change one of the #defines in the CMake source, this uses a newly-provided variable when building CMake to accomplish the same. I tested building Impala with this version of CMake on el7 and it worked fine. [1] https://gitlab.kitware.com/cmake/cmake/merge_requests/430 Change-Id: I1ad46a7b820bbb727ce47219f03f1d4a36301ab4 Reviewed-on: http://gerrit.cloudera.org:8080/13286 Reviewed-by: Laszlo Gaal <laszlo.g...@cloudera.com> Tested-by: Tim Armstrong <tarmstr...@cloudera.com> --- M init.sh M source/cmake/build.sh 2 files changed, 7 insertions(+), 2 deletions(-) Approvals: Laszlo Gaal: Looks good to me, approved Tim Armstrong: Verified -- To view, visit http://gerrit.cloudera.org:8080/13286 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1ad46a7b820bbb727ce47219f03f1d4a36301ab4 Gerrit-Change-Number: 13286 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
