Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13248 )
Change subject: IMPALA-8503: add option to start Kudu cluster with HMS integration ...................................................................... Patch Set 3: (4 comments) > (6 comments) > > I don't have enough context for high-level review of this > changelist, but it seems the comment that Thomas added makes sense. > > Also, what is the way to configure the way how services started via > these scripts? I know that in case of UNIX init.d scripts there > are configuration files in /etc that are picked up by the scripts. > Using environment variables makes it look like something similar to > that approach. Ok, since both of you think using env is better, I updated the patch accordingly. Thanks! http://gerrit.cloudera.org:8080/#/c/13248/1/testdata/cluster/admin File testdata/cluster/admin: http://gerrit.cloudera.org:8080/#/c/13248/1/testdata/cluster/admin@425 PS1, Line 425: > drop Done http://gerrit.cloudera.org:8080/#/c/13248/1/testdata/cluster/admin@427 PS1, Line 427: > drop Done http://gerrit.cloudera.org:8080/#/c/13248/1/testdata/cluster/admin@428 PS1, Line 428: M > drop Done http://gerrit.cloudera.org:8080/#/c/13248/1/testdata/cluster/admin@497 PS1, Line 497: function restart { : if [[ $# -ne 1 ]]; then : echo restart must be called with a single argument -- the service to restart. 1>&2 : exit 1 : fi : local SERVICE=$1 : stop $SERVICE : start $SERVICE : } : : function delete_data { : # Delete namenode, datanode and KMS data while preserving directory structure. : rm -rf "$NODES_DIR/$NODE_PREFIX"*/data/dfs/{nn,dn}/* : rm -f "$NODES_DIR/$NODE_PREFIX"*/data/kms.keystore : delete_kudu_data : } > Did you verify this works as expected? I'm a bit confused about check at L Yeah, I verified. What is the confusing point? -- To view, visit http://gerrit.cloudera.org:8080/13248 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I734d14ede6a03ad52e820e38a1fbcbac0a40ede2 Gerrit-Change-Number: 13248 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Fri, 17 May 2019 05:57:32 +0000 Gerrit-HasComments: Yes