Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13248 )
Change subject: IMPALA-8503: add option to start Kudu cluster with HMS integration ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/13248/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13248/3//COMMIT_MSG@7 PS3, Line 7: IMPALA-8503: add option to start Kudu cluster with HMS integration > Like I said before, its difficult to evaluate this patch without seeing how Sure, I can move it to the CREATE TABLE patch. My initial intention is to avoid large patch, and want to separate the patches based on the functionality. http://gerrit.cloudera.org:8080/#/c/13248/3/testdata/cluster/node_templates/common/etc/init.d/kudu-master File testdata/cluster/node_templates/common/etc/init.d/kudu-master: http://gerrit.cloudera.org:8080/#/c/13248/3/testdata/cluster/node_templates/common/etc/init.d/kudu-master@28 PS3, Line 28: if [[ -n "$ENABLE_KUDU_HMS_INTEGRATION" ]]; then > I think its better if this is more generic, eg. call the env variable IMPAL Done -- To view, visit http://gerrit.cloudera.org:8080/13248 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I734d14ede6a03ad52e820e38a1fbcbac0a40ede2 Gerrit-Change-Number: 13248 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Mon, 20 May 2019 06:28:29 +0000 Gerrit-HasComments: Yes