Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13313 )
Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config ...................................................................... Patch Set 12: (4 comments) http://gerrit.cloudera.org:8080/#/c/13313/12/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/13313/12/tests/shell/test_shell_commandline.py@479 PS12, Line 479: @pytest.mark.execute_serially we dont need this test to execute serially so you can remove it http://gerrit.cloudera.org:8080/#/c/13313/12/tests/shell/test_shell_commandline.py@483 PS12, Line 483: query options this is not being verified http://gerrit.cloudera.org:8080/#/c/13313/12/tests/shell/test_shell_commandline.py@487 PS12, Line 487: assert 'WARNING:' not in result.stderr what is this verifying? http://gerrit.cloudera.org:8080/#/c/13313/12/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/13313/12/tests/shell/test_shell_interactive.py@434 PS12, Line 434: assert "\tDEFAULT_FILE_FORMAT: avro" in result.stdout nit: add a comment above this mentioning that you are verifying id the query option under [impala] overrides the one under [impala.query_options] -- To view, visit http://gerrit.cloudera.org:8080/13313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a3179b6d9c9e3b2b01d6d3c5847cadb68782816 Gerrit-Change-Number: 13313 Gerrit-PatchSet: 12 Gerrit-Owner: Ethan Xue <ethan....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Ethan Xue <ethan....@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 29 May 2019 00:34:54 +0000 Gerrit-HasComments: Yes
