Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13313 )
Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/13313/9/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/13313/9/tests/shell/test_shell_commandline.py@480 PS9, Line 480: test_impalarc nit: rename to test_global_config_file to be consistent with the next test http://gerrit.cloudera.org:8080/#/c/13313/9/tests/shell/test_shell_commandline.py@511 PS9, Line 511: It seems like we can set query options through either [impala] or [impala.query_options] notations. Can you take a look at what the precedence order is if both are defined. It would be good to also add tests that make sure that the order is honored and also file a jira to update the docs accordingly -- To view, visit http://gerrit.cloudera.org:8080/13313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a3179b6d9c9e3b2b01d6d3c5847cadb68782816 Gerrit-Change-Number: 13313 Gerrit-PatchSet: 9 Gerrit-Owner: Ethan Xue <ethan....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Ethan Xue <ethan....@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 23 May 2019 00:53:32 +0000 Gerrit-HasComments: Yes
