Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13582 )
Change subject: IMPALA-8617: Add support for lz4 in parquet ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13582/2/common/thrift/generate_error_codes.py File common/thrift/generate_error_codes.py: http://gerrit.cloudera.org:8080/#/c/13582/2/common/thrift/generate_error_codes.py@421 PS2, Line 421: "LZ4Block: Decompressed size is not correct."), > I think this is probably a result of having abort_on_error=0 by default. Fo it seems we're missing the underlying HDFS path which had the bad block, though. Is it possible to ensure that this gets propagated up? If that's a lot of scope creep for this commit maybe we can file it as a follow-up? My fear is that someone hits this issue and we can't tell them which file is broken. -- To view, visit http://gerrit.cloudera.org:8080/13582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia6850a39ef3f1e0e7ba48e08eef1d4f7cbb74d0c Gerrit-Change-Number: 13582 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 11 Jun 2019 23:08:11 +0000 Gerrit-HasComments: Yes