Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/13582 )
Change subject: IMPALA-8617: Add support for lz4 in parquet ...................................................................... Patch Set 2: (1 comment) Updated the error messages to include file-path and column name. I ended up adding a new member `column_name_` in the class `BaseColumnWriter`. I was able to easily get the file name and column name in the reader so no changes there. http://gerrit.cloudera.org:8080/#/c/13582/2/common/thrift/generate_error_codes.py File common/thrift/generate_error_codes.py: http://gerrit.cloudera.org:8080/#/c/13582/2/common/thrift/generate_error_codes.py@421 PS2, Line 421: "LZ4Block: Decompressed size is not correct."), > Yes! We should include the file path and column name in the error message. I made the change to include file-path and column name in the error message. Examples of error message during read/write below. During read: ``` Parquet file 'hdfs://localhost:20500/test-warehouse/t1_lz4/75420bd1e4493fd8-7bd2b1cc00000000_335390868_data.0.parq' column 'c1' hit an error. LZ4Block: Decompressed size is not correct. ``` During write: ``` Parquet file 'hdfs://localhost:20500/test-warehouse/t1/_impala_insert_staging/6845d8b48f3c98fe_161dbf2000000000/.6845d8b48f3c98fe-161dbf2000000000_1495120350_dir/6845d8b48f3c98fe-161dbf2000000000_825475957_data.0.parq' column 'c1' hit an error. ZSTD_compress failed with error ``` -- To view, visit http://gerrit.cloudera.org:8080/13582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia6850a39ef3f1e0e7ba48e08eef1d4f7cbb74d0c Gerrit-Change-Number: 13582 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 12 Jun 2019 20:47:46 +0000 Gerrit-HasComments: Yes
