Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13653 )
Change subject: IMPALA-8599: Create a Maven module for query event hook API ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13653/2/query-event-hook-api/CMakeLists.txt File query-event-hook-api/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/13653/2/query-event-hook-api/CMakeLists.txt@18 PS2, Line 18: DEPENDS gen-deps impala-parent > qq: why is this needed? Looking at the hook, seems like a standalone thing. It depends on impala-parent because this module uses impala-parent. As for gen-deps, it's currently not needed, but if we need to use anything from Thrift in the future, then we'll need gen-deps. -- To view, visit http://gerrit.cloudera.org:8080/13653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84c422d83c19b75c3d1d7a772b971f4f7704d44c Gerrit-Change-Number: 13653 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 17 Jun 2019 05:04:33 +0000 Gerrit-HasComments: Yes
