Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13653 )
Change subject: IMPALA-8599: Create a Maven module for query event hook API ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Looks fine. We should probably reorganize all this stuff so that the different modules are submodules within a top-level directory with a pom to tie them together (multi-module maven project) instead of depending on each other as separate projects tied together by cmake, but I guess that's out of scope for this patch. Any interest in taking that on? http://gerrit.cloudera.org:8080/#/c/13653/2/query-event-hook-api/pom.xml File query-event-hook-api/pom.xml: http://gerrit.cloudera.org:8080/#/c/13653/2/query-event-hook-api/pom.xml@51 PS2, Line 51: <plugin> : <groupId>org.apache.maven.plugins</groupId> : <artifactId>maven-compiler-plugin</artifactId surprised this isn't set in the parent -- To view, visit http://gerrit.cloudera.org:8080/13653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84c422d83c19b75c3d1d7a772b971f4f7704d44c Gerrit-Change-Number: 13653 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 17 Jun 2019 17:19:05 +0000 Gerrit-HasComments: Yes
