Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/13582 )
Change subject: IMPALA-8617: Add support for lz4 in parquet ...................................................................... Patch Set 7: (2 comments) Updated the tests/custom_cluster/test_hive_parquet_codec_interop.py to loop through the codecs inside the test case and avoid multiple impalad restarts. http://gerrit.cloudera.org:8080/#/c/13582/7/tests/custom_cluster/test_hive_parquet_codec_interop.py File tests/custom_cluster/test_hive_parquet_codec_interop.py: http://gerrit.cloudera.org:8080/#/c/13582/7/tests/custom_cluster/test_hive_parquet_codec_interop.py@32 PS7, Line 32: class TestParquetInterop(CustomClusterTestSuite): > How much time do these tests add to the runtime? My main concern is just th These tests take `2m14.625s` on my dev box. I moved the iteration over compression_codecs inside the test case and it reduces the time by ~1 minute: `1m21.112s`. http://gerrit.cloudera.org:8080/#/c/13582/7/tests/custom_cluster/test_hive_parquet_codec_interop.py@45 PS7, Line 45: cls.ImpalaTestMatrix.add_dimension( > We could reduce the number of parameter combinations by iterating over the Done -- To view, visit http://gerrit.cloudera.org:8080/13582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia6850a39ef3f1e0e7ba48e08eef1d4f7cbb74d0c Gerrit-Change-Number: 13582 Gerrit-PatchSet: 7 Gerrit-Owner: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 18 Jun 2019 21:26:27 +0000 Gerrit-HasComments: Yes
