Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13708 )
Change subject: IMPALA-8627: re-enable catalog v2 in containers ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13708/2/docker/catalogd/Dockerfile File docker/catalogd/Dockerfile: http://gerrit.cloudera.org:8080/#/c/13708/2/docker/catalogd/Dockerfile@27 PS2, Line 27: "-catalog_topic_mode=minimal", "-hms_event_polling_interval_s=1",\ Do you think it would be useful to enable them one by one so that triage of the test failures is easier. This part can be done in a separate patch. I think to truely test if event polling is doing what we expect it to be, we should make sure that the refreshes and invalidates commands which issued in the tests are a no-op. Perhaps introduce a test-only flag to make them a no-op operations when event polling is enabled. -- To view, visit http://gerrit.cloudera.org:8080/13708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b4dd7060c3977c4a943b2492008c1dd601402a2 Gerrit-Change-Number: 13708 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Mon, 24 Jun 2019 18:44:40 +0000 Gerrit-HasComments: Yes
