Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13708 )
Change subject: IMPALA-8627: re-enable catalog v2 in containers ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13708/2/docker/catalogd/Dockerfile File docker/catalogd/Dockerfile: http://gerrit.cloudera.org:8080/#/c/13708/2/docker/catalogd/Dockerfile@27 PS2, Line 27: "-catalog_topic_mode=minimal", "-hms_event_polling_interval_s=1",\ > I noticed we have some tests which try to detect whether "v2" is enabled, n Yeah, I tried to avoid the more granular checks in the tests. I don't see an obvious reason why we couldn't enable metastore polling first, then local catalog, but it does create extra work to go through and figure out which tests need to be updated. So my bias is to just change it all at once, but I'm open to changing my mind. Agree that removing refreshes and invalidates would be interesting, although we'd have to add some kind of polling to wait until the effect of the changes shows up (since we don't have a strong consistency). We also still have to make sure that we have some coverage that refresh/invalidate works with the event processing enabled. -- To view, visit http://gerrit.cloudera.org:8080/13708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b4dd7060c3977c4a943b2492008c1dd601402a2 Gerrit-Change-Number: 13708 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Mon, 24 Jun 2019 20:00:03 +0000 Gerrit-HasComments: Yes
