Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13727 )
Change subject: IMPALA-8698: Disable row count estimate to avoid a flaky test ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13727/2/testdata/workloads/functional-query/queries/QueryTest/bloom_filters.test File testdata/workloads/functional-query/queries/QueryTest/bloom_filters.test: http://gerrit.cloudera.org:8080/#/c/13727/2/testdata/workloads/functional-query/queries/QueryTest/bloom_filters.test@131 PS2, Line 131: SET DISABLE_HDFS_NUM_ROWS_ESTIMATE=1; instead of disabling this feature, I would recommend changing the query to have a deterministic row count like this: select STRAIGHT_JOIN count(*) from (select * from alltypes limit 7300) a join [SHUFFLE] (select * from alltypes limit 7300) b on a.id = b.id; -- To view, visit http://gerrit.cloudera.org:8080/13727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8342bc20a6b7935823d2a8bac2b42afaa1a8aae0 Gerrit-Change-Number: 13727 Gerrit-PatchSet: 3 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 25 Jun 2019 20:47:31 +0000 Gerrit-HasComments: Yes
