Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13727 )
Change subject: IMPALA-8698: Disable row count estimate to avoid a flaky test ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13727/2/testdata/workloads/functional-query/queries/QueryTest/bloom_filters.test File testdata/workloads/functional-query/queries/QueryTest/bloom_filters.test: http://gerrit.cloudera.org:8080/#/c/13727/2/testdata/workloads/functional-query/queries/QueryTest/bloom_filters.test@131 PS2, Line 131: SET DISABLE_HDFS_NUM_ROWS_ESTIMATE=1; > Hi Bikram, thank you very much for your suggestion! According to your sugge Yeah I like the idea of making the test produce the same value for the same reason for all file formats (rather than exercising a different code path). Anyway, I think it's fine that we merged the original fix, since at least that will fix the failing tests and should be fairly stable. We could implement one of the above ideas in a follow-on patch if it works. It's better in principle I think, but at least the test is stable now. -- To view, visit http://gerrit.cloudera.org:8080/13727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8342bc20a6b7935823d2a8bac2b42afaa1a8aae0 Gerrit-Change-Number: 13727 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 26 Jun 2019 06:21:55 +0000 Gerrit-HasComments: Yes
