Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13772 )
Change subject: IMPALA-8732: Use a serialized descriptor table in TQueryCtx ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/13772/1/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/13772/1/be/src/runtime/coordinator-backend-state.cc@200 PS1, Line 200: sidecar.__set_query_ctx(query_ctx()); Makes me wonder if we should factor out the descriptor table from query_ctx() and send the entire serialized descriptor table byte array as a sidecar instead to avoid another malloc + copy in line 213 below. If the above makes sense, it could be a follow-up change to make backporting easier. http://gerrit.cloudera.org:8080/#/c/13772/1/be/src/runtime/descriptors.h File be/src/runtime/descriptors.h: http://gerrit.cloudera.org:8080/#/c/13772/1/be/src/runtime/descriptors.h@480 PS1, Line 480: thrift_tbl stale http://gerrit.cloudera.org:8080/#/c/13772/1/be/src/runtime/descriptors.h@485 PS1, Line 485: thrift_tbl stale -- To view, visit http://gerrit.cloudera.org:8080/13772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I458aa62dd4d1e4e4a7b1869a604623a69f3b2d9a Gerrit-Change-Number: 13772 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Comment-Date: Wed, 03 Jul 2019 00:48:36 +0000 Gerrit-HasComments: Yes
