Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13772 )
Change subject: IMPALA-8732: Use a serialized descriptor table in TQueryCtx ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/13772/4/be/src/runtime/descriptors.h File be/src/runtime/descriptors.h: http://gerrit.cloudera.org:8080/#/c/13772/4/be/src/runtime/descriptors.h@539 PS4, Line 539: WARN_UNUSED_RESULT; > Do DeserializeThrift() and CreateTblDecriptorInternal() also need this ? Good point, I think we should go ahead and keep doing that. I added this to the functions that didn't have it. -- To view, visit http://gerrit.cloudera.org:8080/13772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I458aa62dd4d1e4e4a7b1869a604623a69f3b2d9a Gerrit-Change-Number: 13772 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Comment-Date: Wed, 10 Jul 2019 17:53:46 +0000 Gerrit-HasComments: Yes