Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13849 )
Change subject: IMPALA-8486: fix stale libCache entries in LocalCatalog mode ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13849/3/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/13849/3/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@1215 PS3, Line 1215: // Will refresh the cached file if the mtime of its source file in HDFS changes > Comment seems out of place. Instead say something like "invalidate the libc Sure. Just want to say that the loading after invalidation is lazy. It happens when the function is used again. If the mtime of the hdfs source file does not change, the original libcache entry will be reused. -- To view, visit http://gerrit.cloudera.org:8080/13849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4812fb8737de3ba6074ffeb9007927bfbbbaf9b Gerrit-Change-Number: 13849 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Sat, 13 Jul 2019 03:07:35 +0000 Gerrit-HasComments: Yes
