Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13849 )
Change subject: IMPALA-8486: fix stale libCache entries in LocalCatalog mode ...................................................................... Patch Set 4: > Patch Set 4: > > This makes LocalCatalog behave the same as the old catalog, right? Not strictly the same. The old catalog will remove the libCache entry immediately because it can distinguish create and drop. In LocalCatalog mode, we just mark the libCache entry as "needs refresh", so remove action happens lazily only when the HDFS mtime changes. The reason for this is that we can't distinguish create and drop in LocalCatalog mode. We just receive an invalidate cache signal from the statestore's broadcast. Even the coordinator that creates the function will receive this signal. So we can't just remove the libCache entry. Marking it as "needs refresh" prevent this coordinator removing it again. >In the JIRA I mentioned another couple of issues that would require a rework >of the design. > I think this patch is a step in the right direction and removes a blocker for > the LocalCatalog switch, so maybe we should just file a separate JIRA for the > other issues? Do you mean the race issue? As commented in the JIRA, I think it has been fixed in IMPALA-7534 by https://github.com/apache/impala/commit/8431a95698b6f687ac8862cc6549e1949af0b034 Or do I miss other issues? -- To view, visit http://gerrit.cloudera.org:8080/13849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4812fb8737de3ba6074ffeb9007927bfbbbaf9b Gerrit-Change-Number: 13849 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 15 Jul 2019 16:20:44 +0000 Gerrit-HasComments: No
