Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13765 )
Change subject: IMPALA-8718: Fixed AnalysisException in inline view with outer join complex type column ...................................................................... Patch Set 4: (1 comment) > Patch Set 4: > > (1 comment) Sorry for the wrong comment. I have interests in this problem, but may need more time to verify more context. http://gerrit.cloudera.org:8080/#/c/13765/4/testdata/workloads/functional-query/queries/QueryTest/complex_joins.test File testdata/workloads/functional-query/queries/QueryTest/complex_joins.test: http://gerrit.cloudera.org:8080/#/c/13765/4/testdata/workloads/functional-query/queries/QueryTest/complex_joins.test@38 PS4, Line 38: select count(*) from leftSide l left join rightSide r on l.col1 = r.col1 limit 1; > I think we don't need the "limit 1" here. BTW, if I change the last line to Sorry for my wrong comment... The error I mentioned above is fixed by this patch. Somehow I forgot to restart the cluster after building on this patch. However, this test case (the count(*) one) can run successfully without this patch. We may need another more accurate test case. -- To view, visit http://gerrit.cloudera.org:8080/13765 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ida65503ca4b1342b8fe0049753bc664da227dca9 Gerrit-Change-Number: 13765 Gerrit-PatchSet: 4 Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Comment-Date: Mon, 15 Jul 2019 22:15:34 +0000 Gerrit-HasComments: Yes
