Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13873 )
Change subject: IMPALA-8656: Re-factor PlanRootSink into blocking and buffered implementations ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/13873/1/be/src/exec/blocking-plan-root-sink.h File be/src/exec/blocking-plan-root-sink.h: http://gerrit.cloudera.org:8080/#/c/13873/1/be/src/exec/blocking-plan-root-sink.h@51 PS1, Line 51: BlockingPlanRootSink(TDataSinkId sink_id, const RowDescriptor* row_desc, RuntimeState* state); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/13873/1/be/src/exec/blocking-plan-root-sink.cc File be/src/exec/blocking-plan-root-sink.cc: http://gerrit.cloudera.org:8080/#/c/13873/1/be/src/exec/blocking-plan-root-sink.cc@89 PS1, Line 89: // All rows have been sent by the producer, so wake up the producer so it can set eos to true. line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/13873/1/be/src/exec/blocking-plan-root-sink.cc@116 PS1, Line 116: // Set the shared QueryResultSet pointer 'results_' to the given 'results' object and wake line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/13873/1/be/src/exec/plan-root-sink.cc File be/src/exec/plan-root-sink.cc: http://gerrit.cloudera.org:8080/#/c/13873/1/be/src/exec/plan-root-sink.cc@43 PS1, Line 43: void PlanRootSink::ValidateCollectionSlots(const RowDescriptor& row_desc, RowBatch* batch) { line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/13873 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8786b1a9af68ab0a8a094970d8f955eb20d04bca Gerrit-Change-Number: 13873 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 17 Jul 2019 01:39:37 +0000 Gerrit-HasComments: Yes
