Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13873 to look at the new patch set (#2). Change subject: IMPALA-8656: Re-factor PlanRootSink into blocking and buffered implementations ...................................................................... IMPALA-8656: Re-factor PlanRootSink into blocking and buffered implementations Refactors PlanRootSink into a base class with two subclasses: BlockingPlanRootSink and BufferedPlanRootSink. BlockingPlanRootSink encapsulates the current implementation of PlanRootSink and BufferedPlanRootSink encapsulates a new implementation that will buffer RowBatches in memory until they are read by the client. The implementation of BlockingPlanRootSink is left to future work. A new query option called POOL_QUERY_RESULTS controls whether a BlockingPlanRootSink or a BufferedPlanRootSink is used as the DataSink. POOL_QUERY_RESULTS is false by default. Added a few more docs to PlanRootSink and BlockingPlanRootSink to make the implementation easier to understand. Testing: * Since no new functionality has been added no tests were added * Running core tests Change-Id: I8786b1a9af68ab0a8a094970d8f955eb20d04bca --- M be/src/exec/CMakeLists.txt A be/src/exec/blocking-plan-root-sink.cc A be/src/exec/blocking-plan-root-sink.h A be/src/exec/buffered-plan-root-sink.cc A be/src/exec/buffered-plan-root-sink.h M be/src/exec/data-sink.cc M be/src/exec/plan-root-sink.cc M be/src/exec/plan-root-sink.h M be/src/service/query-options.cc M be/src/service/query-options.h M common/thrift/ImpalaInternalService.thrift M common/thrift/ImpalaService.thrift 12 files changed, 369 insertions(+), 154 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/13873/2 -- To view, visit http://gerrit.cloudera.org:8080/13873 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8786b1a9af68ab0a8a094970d8f955eb20d04bca Gerrit-Change-Number: 13873 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>