Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )
Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode. ...................................................................... Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/12443/7/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/12443/7/be/src/service/impala-http-handler.cc@109 PS7, Line 109: // The /catalog_object endpoint is disabled if local_catalog_mode is used. nit: add why http://gerrit.cloudera.org:8080/#/c/12443/7/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/12443/7/tests/webserver/test_web_pages.py@605 PS7, Line 605: execute_serially why? http://gerrit.cloudera.org:8080/#/c/12443/7/tests/webserver/test_web_pages.py@607 PS7, Line 607: A positive test for /catalog_ob Instead say, check /catalog_obj endpoint is not accessible or something? http://gerrit.cloudera.org:8080/#/c/12443/7/tests/webserver/test_web_pages.py@608 PS7, Line 608: http://localhost:25000 use the URL templates above? http://gerrit.cloudera.org:8080/#/c/12443/7/tests/webserver/test_web_pages.py@609 PS7, Line 609: assert 'No URI handler for '/catalog_object'' \ I'm confused, the description says something else? *not* in catalog mode? http://gerrit.cloudera.org:8080/#/c/12443/7/tests/webserver/test_web_pages.py@610 PS7, Line 610: not in response Can you also scrape the webpage source and make sure it doesn't have a "catalog_object" anywhere? -- To view, visit http://gerrit.cloudera.org:8080/12443 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c Gerrit-Change-Number: 12443 Gerrit-PatchSet: 7 Gerrit-Owner: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 09 Aug 2019 15:54:24 +0000 Gerrit-HasComments: Yes