Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )
Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode. ...................................................................... Patch Set 8: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/12443/8/tests/custom_cluster/test_local_catalog.py File tests/custom_cluster/test_local_catalog.py: http://gerrit.cloudera.org:8080/#/c/12443/8/tests/custom_cluster/test_local_catalog.py@386 PS8, Line 386: in impalad.service.read_debug_webpage('/catalog_object') nit: 4 indent spaces. http://gerrit.cloudera.org:8080/#/c/12443/8/www/catalog.tmpl File www/catalog.tmpl: http://gerrit.cloudera.org:8080/#/c/12443/8/www/catalog.tmpl@42 PS8, Line 42: {{?use_local_catalog}} {{name}} {{/use_local_catalog}} nit: Add a quick comment that /catalog_object is disabled in local catalog mode? -- To view, visit http://gerrit.cloudera.org:8080/12443 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c Gerrit-Change-Number: 12443 Gerrit-PatchSet: 8 Gerrit-Owner: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 16 Aug 2019 18:50:49 +0000 Gerrit-HasComments: Yes
