Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14038 )
Change subject: IMPALA-8823: DROP TABLE support for insert-only ACID tables ...................................................................... Patch Set 8: (5 comments) Re-wrote the code to do the locking and heartbeating from catalogd instead. This also cleaned up the code a little bit. http://gerrit.cloudera.org:8080/#/c/14038/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14038/7//COMMIT_MSG@10 PS7, Line 10: Impala acquires an exclusive table lock in HMS > It should be added that locking happens in Coordinator - the other candidat I decided to do the locking from catalogd instead, as you suggested. Thanks for the explanation. http://gerrit.cloudera.org:8080/#/c/14038/5/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/14038/5/fe/src/main/java/org/apache/impala/service/Frontend.java@510 PS5, Line 510: setTr > Can you add a comment about this? Being able to delete tables in problemati I'm not sure what comment you expect here. http://gerrit.cloudera.org:8080/#/c/14038/5/fe/src/main/java/org/apache/impala/service/Frontend.java@1721 PS5, Line 1721: long txnId = queryCtx.getTransaction_id(); : return MetastoreShim.allocateTableWriteId(hmsClient, txnId > I think that it would make sense to try to clean up leaked locks faster the Thanks for opening a Jira for this! http://gerrit.cloudera.org:8080/#/c/14038/7/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/14038/7/fe/src/main/java/org/apache/impala/service/Frontend.java@1716 PS7, Line 1716: f (!AcidU > typo: Releases Done http://gerrit.cloudera.org:8080/#/c/14038/5/testdata/workloads/functional-query/queries/QueryTest/acid.test File testdata/workloads/functional-query/queries/QueryTest/acid.test: http://gerrit.cloudera.org:8080/#/c/14038/5/testdata/workloads/functional-query/queries/QueryTest/acid.test@79 PS5, Line 79: ---- RESULTS > invalidate metadata still remained here. Done -- To view, visit http://gerrit.cloudera.org:8080/14038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic41ca73268c4b75af5a08fe3dd1ada1df3f6fd34 Gerrit-Change-Number: 14038 Gerrit-PatchSet: 8 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 13 Aug 2019 08:59:24 +0000 Gerrit-HasComments: Yes
