Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14038 )
Change subject: IMPALA-8823: DROP TABLE support for insert-only ACID tables ...................................................................... Patch Set 9: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/14038/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14038/9//COMMIT_MSG@17 PS9, Line 17: nit: could you add a paragraph about testing? http://gerrit.cloudera.org:8080/#/c/14038/9/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/14038/9/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@604 PS9, Line 604: LOG.info("Releasing lock: " + lockId); nit: I think we should log both acquire and release, or don't log any of them. http://gerrit.cloudera.org:8080/#/c/14038/9/fe/src/main/java/org/apache/impala/common/TransactionKeepalive.java File fe/src/main/java/org/apache/impala/common/TransactionKeepalive.java: http://gerrit.cloudera.org:8080/#/c/14038/9/fe/src/main/java/org/apache/impala/common/TransactionKeepalive.java@57 PS9, Line 57: If the heartbeating is initialized from the : // coordinator then queryCtx is populated if it is initialized from the catalogd there : // is no TQueryCtx available so a cause string is populated. nit: I'd rather explain what it does than how it is currently used. -- To view, visit http://gerrit.cloudera.org:8080/14038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic41ca73268c4b75af5a08fe3dd1ada1df3f6fd34 Gerrit-Change-Number: 14038 Gerrit-PatchSet: 9 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 13 Aug 2019 12:41:33 +0000 Gerrit-HasComments: Yes
