Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14132 )
Change subject: IMPALA-7604: part 2: fixes for AggregationNode cardinality ...................................................................... Patch Set 6: Code-Review+2 (1 comment) Lgtm http://gerrit.cloudera.org:8080/#/c/14132/6/fe/src/test/java/org/apache/impala/planner/CardinalityTest.java File fe/src/test/java/org/apache/impala/planner/CardinalityTest.java: http://gerrit.cloudera.org:8080/#/c/14132/6/fe/src/test/java/org/apache/impala/planner/CardinalityTest.java@369 PS6, Line 369: 12760 I am not really familiar with the file size estimation logic, but I have noticed file sizes change between data loading jobs, would that affect this test and make it flaky? -- To view, visit http://gerrit.cloudera.org:8080/14132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieed41d60c0e0dfeca64035e919cb8c28a054a9ab Gerrit-Change-Number: 14132 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 27 Aug 2019 22:46:37 +0000 Gerrit-HasComments: Yes
