Hello Bharath Vissapragada, Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14132
to look at the new patch set (#7).
Change subject: IMPALA-7604: part 2: fixes for AggregationNode cardinality
......................................................................
IMPALA-7604: part 2: fixes for AggregationNode cardinality
* Use saturating arithmetic in Expr.getNumDistinctValues() to
avoid overflows.
* Avoid double-adding with checkedAdd()
* Fix incorrect logic with multiple groups - each group cannot
return more than the input rows, but with multiple groups
it can add up to more than the input rows.
Testing:
Updated planner tests from part 1 to reflect bugfixes.
Added targeted cardinality tests to verify behaviour
with and without stats.
Updated other planner tests that changed as a result of
this fixed.
Ran exhaustive tests.
Change-Id: Ieed41d60c0e0dfeca64035e919cb8c28a054a9ab
---
M fe/src/main/java/org/apache/impala/analysis/Expr.java
M fe/src/main/java/org/apache/impala/planner/AggregationNode.java
M fe/src/test/java/org/apache/impala/planner/CardinalityTest.java
M shell/impala_shell.py
M testdata/workloads/functional-planner/queries/PlannerTest/card-agg.test
M testdata/workloads/functional-planner/queries/PlannerTest/empty.test
M testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by.test
M testdata/workloads/functional-planner/queries/PlannerTest/joins.test
M testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test
9 files changed, 965 insertions(+), 854 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/14132/7
--
To view, visit http://gerrit.cloudera.org:8080/14132
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieed41d60c0e0dfeca64035e919cb8c28a054a9ab
Gerrit-Change-Number: 14132
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
