Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14134 )
Change subject: IMPALA-8797: Support database and table blacklist ...................................................................... Patch Set 9: (3 comments) lgtm, can +2 it once the TableName#analyze() is refactored to include the blacklist checks. http://gerrit.cloudera.org:8080/#/c/14134/8/fe/src/main/java/org/apache/impala/analysis/TableName.java File fe/src/main/java/org/apache/impala/analysis/TableName.java: http://gerrit.cloudera.org:8080/#/c/14134/8/fe/src/main/java/org/apache/impala/analysis/TableName.java@86 PS8, Line 86: throw new AnalysisException("Invalid table/view name: " + tbl_); > I think they should always be called together. But BlacklistUtils.verifyTab I think we can add the getFqTableName() logic into BlackListUtils.verifyTableName(). My concern with separating these too is that if someone adds a new Statement in the future that involves a tableName and they forget to to call BlackListUtils.verify(), we might run into issues. Instead folding that logic into TableName#analyze() makes life easier. http://gerrit.cloudera.org:8080/#/c/14134/8/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/14134/8/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1519 PS8, Line 1519: addSummary(resp, "Can't drop blacklisted database: " + dbName); > This is tested in tests/custom_cluster/test_blacklisted_dbs_and_tables.py: ack, sorry missed it. http://gerrit.cloudera.org:8080/#/c/14134/8/fe/src/main/java/org/apache/impala/util/BlacklistUtils.java File fe/src/main/java/org/apache/impala/util/BlacklistUtils.java: http://gerrit.cloudera.org:8080/#/c/14134/8/fe/src/main/java/org/apache/impala/util/BlacklistUtils.java@32 PS8, Line 32: > Sure. What about CatalogBlacklistUtils? sgtm -- To view, visit http://gerrit.cloudera.org:8080/14134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02dbb07f8e08793b57b2a88d09b30fd32cff26dc Gerrit-Change-Number: 14134 Gerrit-PatchSet: 9 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 04 Sep 2019 17:47:51 +0000 Gerrit-HasComments: Yes
