Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14134 )
Change subject: IMPALA-8797: Support database and table blacklist ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/14134/10/fe/src/main/java/org/apache/impala/util/CatalogBlacklistUtils.java File fe/src/main/java/org/apache/impala/util/CatalogBlacklistUtils.java: http://gerrit.cloudera.org:8080/#/c/14134/10/fe/src/main/java/org/apache/impala/util/CatalogBlacklistUtils.java@104 PS10, Line 104: if (BLACKLISTED_TABLES.contains(table)) { Can we just do TableName temp = analyzer.getFqTableName(table); if (BLACKLISTED_TABLES.contains(temp)) { ..... That saves all the callers from doing analyzer.getFqTableName(tableName_).analyze(); -- To view, visit http://gerrit.cloudera.org:8080/14134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02dbb07f8e08793b57b2a88d09b30fd32cff26dc Gerrit-Change-Number: 14134 Gerrit-PatchSet: 10 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Thu, 05 Sep 2019 00:46:07 +0000 Gerrit-HasComments: Yes