Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14247 )
Change subject: IMPALA-8942: Set file format specific split sizes on non-block stores ...................................................................... Patch Set 1: (1 comment) First pass, the code looks good. A quick thought on the name of the query option. I need to think through the test in test_scanners.py. http://gerrit.cloudera.org:8080/#/c/14247/1/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/14247/1/be/src/service/query-options.h@192 PS1, Line 192: QUERY_OPT_FN(parquet_non_block_split_size, PARQUET_NON_BLOCK_SPLIT_SIZE,\ Since this is primarily used by object stores (I think the only exception is the local filesystem), an alternative is to name this PARQUET_OBJECT_STORE_SPLIT_SIZE. -- To view, visit http://gerrit.cloudera.org:8080/14247 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0995b2a3b732d39d6f58e9b3bb04111ac04601e6 Gerrit-Change-Number: 14247 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Wed, 18 Sep 2019 21:02:46 +0000 Gerrit-HasComments: Yes
