Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14247 )
Change subject: IMPALA-8942: Set file format specific split sizes on non-block stores ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/14247/3/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/14247/3/be/src/service/query-options.cc@881 PS3, Line 881: int64_t parquet_object_store_split_size; : RETURN_IF_ERROR(ParseMemValue( : value, "parquet object store split size", &parquet_object_store_split_size)); : query_options->__set_parquet_object_store_split_size( : parquet_object_store_split_size); : break; > We won't respect a value below 1MB (due to MIN_SYNTHETIC_BLOCK_SIZE), but d Done http://gerrit.cloudera.org:8080/#/c/14247/3/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/14247/3/tests/query_test/test_scanners.py@995 PS3, Line 995: num_row_groups_counters = re.findall(r'NumRowGroups: (\d+)', result.runtime_profile) : assert len(num_row_groups_counters) > 1 > I think this test would fail if the code wasn't working. I think there are Done -- To view, visit http://gerrit.cloudera.org:8080/14247 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0995b2a3b732d39d6f58e9b3bb04111ac04601e6 Gerrit-Change-Number: 14247 Gerrit-PatchSet: 3 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Fri, 20 Sep 2019 18:02:30 +0000 Gerrit-HasComments: Yes
