Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14311 )
Change subject: IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14311/2/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/14311/2/tests/common/impala_test_suite.py@184 PS2, Line 184: # 'filesystem_client' is set depending on the value of the 'TARGET_FILESYSTEM'. For : # HDFS, it is the same as the 'hdfs_client'. For S3 and and ABFS, the client is a : # HadoopFsCommandLineClient which is a simple wrapper around 'hdfs dfs' commands. : # For ADLS, the 'filesystem_client' is an ADLSClient. When would you use filesystem_client vs fs_cli_client? I think it would be nice to combine these so test writers don't need to think about it. It seems like PyWebHdfsClientWithChmod could implement a put/copyFromLocal. Or, the client for HDFS could use PyWebHdfsClientWithChmod for some operations and the HadoopFsCommandLineClient for others. Or, we could use HadoopFsCommandLineClient for everything. ADLSv1 (which uses the ADLSClient for fileystem_client) is one obstacle, but I think HadoopFsCommandLineClient might handle that. -- To view, visit http://gerrit.cloudera.org:8080/14311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d45db1c00554e6fb6bcc0b552596d86d4e30144 Gerrit-Change-Number: 14311 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Thu, 26 Sep 2019 20:35:59 +0000 Gerrit-HasComments: Yes
