Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14311 )
Change subject: IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/14311/2/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/14311/2/tests/common/impala_test_suite.py@184 PS2, Line 184: # 'filesystem_client' is set depending on the value of the 'TARGET_FILESYSTEM'. For : # HDFS, it is the same as the 'hdfs_client'. For S3 and and ABFS, the client is a : # HadoopFsCommandLineClient which is a simple wrapper around 'hdfs dfs' commands. : # For ADLS, the 'filesystem_client' is an ADLSClient. > Merged the two. Created a DelegatingHdfsFilesystem extends the BaseFilesyst Created a DelegatingHdfsFilesystem *that* extends... http://gerrit.cloudera.org:8080/#/c/14311/3/tests/query_test/test_hdfs_file_mods.py File tests/query_test/test_hdfs_file_mods.py: http://gerrit.cloudera.org:8080/#/c/14311/3/tests/query_test/test_hdfs_file_mods.py@59 PS3, Line 59: > flake8: E501 line too long (94 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/14311/3/tests/query_test/test_multiple_filesystems.py File tests/query_test/test_multiple_filesystems.py: http://gerrit.cloudera.org:8080/#/c/14311/3/tests/query_test/test_multiple_filesystems.py@52 PS3, Line 52: > flake8: E501 line too long (91 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/14311/3/tests/util/adls_util.py File tests/util/adls_util.py: http://gerrit.cloudera.org:8080/#/c/14311/3/tests/util/adls_util.py@34 PS3, Line 34: > flake8: F821 undefined name 'HadoopFsCommandLineClient' Done -- To view, visit http://gerrit.cloudera.org:8080/14311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d45db1c00554e6fb6bcc0b552596d86d4e30144 Gerrit-Change-Number: 14311 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Fri, 27 Sep 2019 01:15:14 +0000 Gerrit-HasComments: Yes
