Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14311 )
Change subject: IMPALA-8950: Add -d, -f options to hdfs copyFromLocal, put, cp ...................................................................... Patch Set 4: (2 comments) Addressed comments + fixed a bunch of issues that popped up when I ran exhaustive tests. http://gerrit.cloudera.org:8080/#/c/14311/4/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/14311/4/tests/common/impala_test_suite.py@179 PS4, Line 179: # There are multiple clients for interacting with the underlying storage service. : # : # There are two main types of clients: HTTP clients and CLI clients. CLI clients all : # use the 'hdfs dfs' CLI to execute operations againt a target filesystem. HTTP : # clients issue HTTP requests to execute operations and are filesystem specific. For : # HDFS, the HTTP client uses WebHDFS. : # : # 'hdfs_client' is a wrapper around a HTTP client and CLI client for interacting : # with HDFS. The 'hdfs_client' delegates to the HTTP client when possible, and for : # operations not supported by the HTTP client, it delegates to the CLI client. The : # 'hdfs_client' is specific to HDFS and always points to the local HDFS cluster. : # : # 'filesystem_client' is set depending on the value of the 'TARGET_FILESYSTEM'. For : # HDFS, it is the same as the 'hdfs_client'. For S3 and and ABFS, the client is a : # HadoopFsCommandLineClient which is a simple wrapper around 'hdfs dfs' commands. : # For ADLS, the 'filesystem_client' is an ADLSClient. > These are mostly nits, but here goes: Done. Attempted to incorporate everything you wrote above + some of the existing text. http://gerrit.cloudera.org:8080/#/c/14311/4/tests/util/hdfs_util.py File tests/util/hdfs_util.py: http://gerrit.cloudera.org:8080/#/c/14311/4/tests/util/hdfs_util.py@58 PS4, Line 58: DelegatingHdfsFilesystem > Nit: The other clients all have "Client" in their name rather than Filesyst Done -- To view, visit http://gerrit.cloudera.org:8080/14311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d45db1c00554e6fb6bcc0b552596d86d4e30144 Gerrit-Change-Number: 14311 Gerrit-PatchSet: 4 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Wed, 02 Oct 2019 20:51:19 +0000 Gerrit-HasComments: Yes
