Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14337 )
Change subject: IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14337/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/14337/1/tests/custom_cluster/test_admission_controller.py@1337 PS1, Line 1337: sleep(30) # Wait for the 'lineitem' scan to complete > assert_eventually still has a timeout itself so it will suffer the same tim The test itself is timing dependent, so I don't think we can get out of using timeouts. The test runs a query where some fragments block indefinitely, and others Even checking the status of the in-flight fragments will have to be done with a timeout. The reason I want to use NumCompletedBackends, is that this feature should increment NumCompletedBackends whenever a backend completes. If it doesn't, then that is a bug. NumCompletedBackends was added as part of this feature. Using assert_eventually should be more robust than the previous approach of just sleeping for a fixed amount of time and then asserting that NumCompletedBackends == 1. assert_eventually polls the runtime profile at a fixed interval and validates that the value of NumCompletedBackends eventually reaches 1, within a timeout of 30 seconds. The previous approach just wanted for 10 seconds, and then asserted that NumCompletedBackends == 1. We could even increase the timeout to a higher value, like 60 if necessary. -- To view, visit http://gerrit.cloudera.org:8080/14337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ea6bf3d84f174745c8a0b1e0f2b55ce05ee618b Gerrit-Change-Number: 14337 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Wed, 02 Oct 2019 21:07:04 +0000 Gerrit-HasComments: Yes
