Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14337 )
Change subject: IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14337/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/14337/1/tests/custom_cluster/test_admission_controller.py@1337 PS1, Line 1337: sleep(30) # Wait for the 'lineitem' scan to complete > Not sure if there is any misunderstanding here. I understand the purpose of Yeah, maybe discussing in person is best, will find you tomorrow. I get that waiting for for all F01 instances to transition to "FINISHED" is a prerequisite for NumCompletedBackends == 1, I guess my question is what is the benefit of doing that check? How would it reduce flakiness? You would end up with code like: assert_eventually(1, 30, lambda: [method-to-check-F01-fragments-finished]) assert_eventually(1, 30, lamdba: "NumCompletedBackends: 1 (1)" in self.client.get_runtime_profile(handle))) I don't see how that is better than just doing: assert_eventually(1, 30, lamdba: "NumCompletedBackends: 1 (1)" in self.client.get_runtime_profile(handle))) Given that NumCompletedBackends should be set to 1 at roughly the same time all F01 fragments finish. -- To view, visit http://gerrit.cloudera.org:8080/14337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ea6bf3d84f174745c8a0b1e0f2b55ce05ee618b Gerrit-Change-Number: 14337 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Wed, 02 Oct 2019 23:53:58 +0000 Gerrit-HasComments: Yes