Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/14183 )
Change subject: IMPALA-8830: Fix executor group assignment of coordinator only queries ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/14183/5/be/src/scheduling/admission-controller.h File be/src/scheduling/admission-controller.h: http://gerrit.cloudera.org:8080/#/c/14183/5/be/src/scheduling/admission-controller.h@973 PS5, Line 973: /// the query is a coordinator only query, then a reserved empty group is returned nit: punctuation http://gerrit.cloudera.org:8080/#/c/14183/5/be/src/scheduling/scheduler.h File be/src/scheduling/scheduler.h: http://gerrit.cloudera.org:8080/#/c/14183/5/be/src/scheduling/scheduler.h@72 PS5, Line 72: /// ranges in the query exec request. Mention here that executor_config must contain a non-empty group unless IsCoordinatorOnlyQuery() is true? http://gerrit.cloudera.org:8080/#/c/14183/5/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/14183/5/be/src/scheduling/scheduler.cc@143 PS5, Line 143: bool exec_at_coord = (fragment.partition.type == TPartitionType::UNPARTITIONED); Can we add a DCHECK to verify that exec_at_coord is true if executor_config only contains the empty group? It's probably implicitly checked by the assignment computation, but I think it would be good to tie this together with IsCoordinatorQuery(). http://gerrit.cloudera.org:8080/#/c/14183/5/be/src/scheduling/scheduler.cc@466 PS5, Line 466: // case. I think here it would help future-us if we include the purpose of this group, e.g similar to this: > This group is used to schedule fragments where the caller of this method has > determined that they need to be scheduled on the coordinator only. Note that > this includes queries where the whole query should run on the coordinator, as > is determined by Scheduler::IsCoordinatorOnlyQuery(). For those queries, the > AdmissionController will pass an empty executor group and rely on this method > being called with exec_at_coord = true. -- To view, visit http://gerrit.cloudera.org:8080/14183 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8fe098032744aa20bbbe4faddfc67e7a46ce03d5 Gerrit-Change-Number: 14183 Gerrit-PatchSet: 5 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Comment-Date: Thu, 03 Oct 2019 23:03:02 +0000 Gerrit-HasComments: Yes
