Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14183 )
Change subject: IMPALA-8830: Fix executor group assignment of coordinator only queries ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/14183/5/be/src/scheduling/admission-controller.h File be/src/scheduling/admission-controller.h: http://gerrit.cloudera.org:8080/#/c/14183/5/be/src/scheduling/admission-controller.h@973 PS5, Line 973: /// the query is a coordinator only query then a reserved empty group is returned > nit: punctuation Done http://gerrit.cloudera.org:8080/#/c/14183/5/be/src/scheduling/scheduler.h File be/src/scheduling/scheduler.h: http://gerrit.cloudera.org:8080/#/c/14183/5/be/src/scheduling/scheduler.h@72 PS5, Line 72: /// ranges in the query exec request. 'executor_config' must contain a non-empty group > Mention here that executor_config must contain a non-empty group unless IsC Done http://gerrit.cloudera.org:8080/#/c/14183/5/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/14183/5/be/src/scheduling/scheduler.cc@143 PS5, Line 143: bool exec_at_coord = (fragment.partition.type == TPartitionType::UNPARTITIONED); > Can we add a DCHECK to verify that exec_at_coord is true if executor_config Done http://gerrit.cloudera.org:8080/#/c/14183/5/be/src/scheduling/scheduler.cc@466 PS5, Line 466: // used to schedule scan ranges for the plan node passed where the caller of this method > I think here it would help future-us if we include the purpose of this grou Done. Slightly modified your suggested description to mention scan ranges being assigned for plan nodes -- To view, visit http://gerrit.cloudera.org:8080/14183 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8fe098032744aa20bbbe4faddfc67e7a46ce03d5 Gerrit-Change-Number: 14183 Gerrit-PatchSet: 6 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Comment-Date: Wed, 09 Oct 2019 00:26:38 +0000 Gerrit-HasComments: Yes
