Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14588 )
Change subject: IMPALA-6660: Change -0/+0 floating point to compare as equal in hash table ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/14588/3/be/src/codegen/codegen-anyval.h File be/src/codegen/codegen-anyval.h: http://gerrit.cloudera.org:8080/#/c/14588/3/be/src/codegen/codegen-anyval.h@248 PS3, Line 248: // Replaces negative zero with positive, leaves everything else unchanged. > nit: maybe mention that it is for floating point numbers Done http://gerrit.cloudera.org:8080/#/c/14588/3/be/src/runtime/raw-value.inline.h File be/src/runtime/raw-value.inline.h: http://gerrit.cloudera.org:8080/#/c/14588/3/be/src/runtime/raw-value.inline.h@57 PS3, Line 57: std::abs > is std::abs needed? Done -- To view, visit http://gerrit.cloudera.org:8080/14588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6bb1a817c81c452d041238c19cb6c9f602a5d565 Gerrit-Change-Number: 14588 Gerrit-PatchSet: 3 Gerrit-Owner: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 14 Nov 2019 08:54:19 +0000 Gerrit-HasComments: Yes
