Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14588 )
Change subject: IMPALA-6660: Change -0/+0 floating point to compare as equal in hash table ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Thanks for fixing! http://gerrit.cloudera.org:8080/#/c/14588/5/be/src/runtime/raw-value.h File be/src/runtime/raw-value.h: http://gerrit.cloudera.org:8080/#/c/14588/5/be/src/runtime/raw-value.h@46 PS5, Line 46: static const double CANONICAL_DOUBLE_ZERO; I'd suggest putting the value here instead of in the .cc, so that the value can be inlined into other .cc files. I.e. // in .h static const double CANONICAL_DOUBLE_ZERO = 0.0; // in .cc const double RawValue::CANONICAL_DOUBLE_ZERO; Probably not that important in this case, but there's other more perf-critical code where using this pattern makes a different and I'd prefer that the best practice be used consistently in the codebase. The neighbouring code here was using the suboptimal pattern. I've seen this kinda thing make a difference in very tight loops, e.g. some of the parquet code. -- To view, visit http://gerrit.cloudera.org:8080/14588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6bb1a817c81c452d041238c19cb6c9f602a5d565 Gerrit-Change-Number: 14588 Gerrit-PatchSet: 5 Gerrit-Owner: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 21 Nov 2019 00:43:10 +0000 Gerrit-HasComments: Yes
