Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14750 )
Change subject: IMPALA-9092: Add support for creating external Kudu table ...................................................................... Patch Set 4: (33 comments) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java: http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@71 PS4, Line 71: super.AnalysisError(appendSynchronizedTblProps(stmt, isExternalPurgeTbl), expectedError); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@102 PS4, Line 102: "range(x, y) (partition value = (1+1, 2+2), partition value = ((1+1+1)+1, 10), " + line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@221 PS4, Line 221: "(PARTITION VALUE = 'abc')' is not a key column. Only key columns can be used " line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@277 PS4, Line 277: "partition by range(a, b) (partition (0, 0) < values <= (1, 1)) stored as kudu", line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@286 PS4, Line 286: "partitioning columns: (1 vs 2). Range partition: 'PARTITION 0 < VALUES <= 1'", line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java File fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java: http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@270 PS4, Line 270: " id INT NOT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@271 PS4, Line 271: " bool_col BOOLEAN NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@272 PS4, Line 272: " tinyint_col TINYINT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@273 PS4, Line 273: " smallint_col SMALLINT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@274 PS4, Line 274: " int_col INT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@275 PS4, Line 275: " bigint_col BIGINT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@276 PS4, Line 276: " float_col FLOAT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@277 PS4, Line 277: " double_col DOUBLE NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@278 PS4, Line 278: " date_string_col STRING NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@279 PS4, Line 279: " string_col STRING NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@280 PS4, Line 280: " timestamp_col TIMESTAMP NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@281 PS4, Line 281: " year INT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@282 PS4, Line 282: " month INT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@297 PS4, Line 297: " id INT NOT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@298 PS4, Line 298: " bool_col BOOLEAN NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@299 PS4, Line 299: " tinyint_col TINYINT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@300 PS4, Line 300: " smallint_col SMALLINT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@301 PS4, Line 301: " int_col INT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@302 PS4, Line 302: " bigint_col BIGINT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@303 PS4, Line 303: " float_col FLOAT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@304 PS4, Line 304: " double_col DOUBLE NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@305 PS4, Line 305: " date_string_col STRING NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@306 PS4, Line 306: " string_col STRING NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@307 PS4, Line 307: " timestamp_col TIMESTAMP NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@308 PS4, Line 308: " year INT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@309 PS4, Line 309: " month INT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/14750/4/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/14750/4/tests/query_test/test_kudu.py@1053 PS4, Line 1053: ' flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/14750/4/tests/query_test/test_kudu.py@1072 PS4, Line 1072: ' flake8: E501 line too long (95 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/14750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76f81d41db0cf2269ee1b365857164a43677e14d Gerrit-Change-Number: 14750 Gerrit-PatchSet: 4 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Thu, 21 Nov 2019 21:14:11 +0000 Gerrit-HasComments: Yes
