Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14750 )
Change subject: IMPALA-9092: Add support for creating external Kudu table ...................................................................... Patch Set 4: Code-Review+1 (2 comments) LGTM, just a couple tiny things that I don't feel too strongly about. Would be great if Hao and/or Grant did a pass too. http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java: http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@499 PS4, Line 499: isSynchronizedTable nit: maybe update this too, and TestCreateSynchronizedKuduTable, to refer to external purge tables? http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java File fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java: http://gerrit.cloudera.org:8080/#/c/14750/4/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@291 PS4, Line 291: Assert.assertTrue("Synchronized Kudu tables in Hive-3 must contain external.table" : + ".purge table property", output.contains("'external.table.purge'='TRUE'")); Do you think it's worth checking that the table property TRANSLATED_TO_EXTERNAL is missing? -- To view, visit http://gerrit.cloudera.org:8080/14750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76f81d41db0cf2269ee1b365857164a43677e14d Gerrit-Change-Number: 14750 Gerrit-PatchSet: 4 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Thu, 21 Nov 2019 22:03:01 +0000 Gerrit-HasComments: Yes
