Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14794 )
Change subject: IMPALA-9196: Dump jstack and collect logs when tests timeout ...................................................................... Patch Set 2: I'm uncertain about how the privileges work. There are ptrace limitations in Ubuntu that restrict ptrace by the same user to a parent process, which I think is why the gdb part of this script works. I'm not sure what permissions jstack would need, and if this would work. If you haven't already, a test that you could run for the permissions is to run the end to end tests and set TIMEOUT_FOR_RUN_ALL_TESTS_MINS to some modest value (15 mins) and verify you get the logs you want and jstack works. Once we verify that the permissions are ok in the normal way we run this, the code looks good to me. -- To view, visit http://gerrit.cloudera.org:8080/14794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8a5b140024c236209c7e44149660189890b9d06 Gerrit-Change-Number: 14794 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Tue, 26 Nov 2019 01:32:20 +0000 Gerrit-HasComments: No
