Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14794 )
Change subject: IMPALA-9196: Dump jstack and collect logs when tests timeout ...................................................................... Patch Set 2: > Patch Set 2: > > > I'm uncertain about how the privileges work. There are ptrace > > limitations in Ubuntu that restrict ptrace by the same user to a > > parent process, which I think is why the gdb part of this script > > works. I'm not sure what permissions jstack would need, and if this > > would work. > > > > If you haven't already, a test that you could run for the > > permissions is to run the end to end tests and set > > TIMEOUT_FOR_RUN_ALL_TESTS_MINS to some modest value (15 mins) and > > verify you get the logs you want and jstack works. > > > > Once we verify that the permissions are ok in the normal way we run > > this, the code looks good to me. > > Circling back to this review. My guess is that this doesn't work in its > current form on Ubuntu, but it might work on other platforms. > > It looks like it is harmless if these debug commands fail (because the script > doesn't have "set -euo pipefail"). I think any step forward in this debugging > information is ok to merge as long as it improves some platform without > regressing anything. We should add comments about dump statements that don't > work on some platforms, but that shouldn't stop us from adding statements > that do work on Centos7 or some other platform. Obviously, it would be nice > for these things to work on Ubuntu. I'm still testing this script in internal jenkeins jobs. It looks wired to me that the script fails with "lsof: command not found". But when installing lsof explictly, it saids it's already installed: ++ sudo yum install -y lsof Loaded plugins: fastestmirror Loading mirror speeds from cached hostfile Package lsof-4.87-4.el7.x86_64 already installed and latest version Nothing to do ++ which lsof which: no lsof in (/usr/lib64/qt-3.3/bin:/usr/lib64/ccache:/usr/local/bin:/usr/bin) I think it's the problem with PATH. Will check it later. Internal job link: https://master-02.jenkins.cloudera.com/job/impala-private-parameterized/6139 -- To view, visit http://gerrit.cloudera.org:8080/14794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8a5b140024c236209c7e44149660189890b9d06 Gerrit-Change-Number: 14794 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Wed, 04 Dec 2019 00:34:54 +0000 Gerrit-HasComments: No
