Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14917 )
Change subject: IMPALA-9197: make HashTable lookups thread-safe ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/14917/4/be/src/exec/hash-table.h File be/src/exec/hash-table.h: http://gerrit.cloudera.org:8080/#/c/14917/4/be/src/exec/hash-table.h@71 PS4, Line 71: /// Operations that mutate the hash table are thread-safe. Read-only access to the hash Maybe "not" is missing here? http://gerrit.cloudera.org:8080/#/c/14917/4/be/src/exec/hash-table.cc File be/src/exec/hash-table.cc: http://gerrit.cloudera.org:8080/#/c/14917/4/be/src/exec/hash-table.cc@164 PS4, Line 164: / Shouldn't we handle division by zero here? -- To view, visit http://gerrit.cloudera.org:8080/14917 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92fbfa8cc000477b8e01975a102d818f9fa27c61 Gerrit-Change-Number: 14917 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 18 Dec 2019 17:32:12 +0000 Gerrit-HasComments: Yes
