Hello Csaba Ringhofer, Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14917
to look at the new patch set (#6).
Change subject: IMPALA-9197: make HashTable lookups thread-safe
......................................................................
IMPALA-9197: make HashTable lookups thread-safe
This makes it possible to do HashTable lookups from
multiple threads without any data races. This
requires moving statistics that are updated during
probing to the HashTableCtx object.
There are some small changes to the hash table stat
logging behaviour as a result of the stats being moved
to the context. I don't believe these logs are used much,
if at all.
Testing:
Ran exhaustive tests.
Manually inspected some aggregation and join query profiles
to check that hash table stats looked reasonable.
Perf:
Ran TPC-H scale factor 30 on a single node. No significant
change in perf.
Change-Id: I92fbfa8cc000477b8e01975a102d818f9fa27c61
---
M be/src/exec/grouping-aggregator.cc
M be/src/exec/grouping-aggregator.h
M be/src/exec/hash-table.cc
M be/src/exec/hash-table.h
M be/src/exec/hash-table.inline.h
M be/src/exec/partitioned-hash-join-builder.cc
M be/src/exec/partitioned-hash-join-builder.h
M be/src/exec/partitioned-hash-join-node.cc
8 files changed, 136 insertions(+), 71 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/14917/6
--
To view, visit http://gerrit.cloudera.org:8080/14917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I92fbfa8cc000477b8e01975a102d818f9fa27c61
Gerrit-Change-Number: 14917
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
